From b27f0ca165c38b83f5310b463f4579f61d48902b Mon Sep 17 00:00:00 2001 From: meowarex Date: Wed, 11 Feb 2026 20:46:07 +1100 Subject: [PATCH] CodeReview Changes --- Reference/BetterLyrics | 1 - Reference/applemusic-like-lyrics | 1 - Reference/luna-plugins | 1 - plugins/radiant-lyrics-luna/src/Settings.tsx | 121 +++++++++++-------- plugins/radiant-lyrics-luna/src/index.ts | 8 +- 5 files changed, 78 insertions(+), 54 deletions(-) delete mode 160000 Reference/BetterLyrics delete mode 160000 Reference/applemusic-like-lyrics delete mode 160000 Reference/luna-plugins diff --git a/Reference/BetterLyrics b/Reference/BetterLyrics deleted file mode 160000 index d6393c6..0000000 --- a/Reference/BetterLyrics +++ /dev/null @@ -1 +0,0 @@ -Subproject commit d6393c6739087005374abf6ce5ddea023ff5b078 diff --git a/Reference/applemusic-like-lyrics b/Reference/applemusic-like-lyrics deleted file mode 160000 index 48fb050..0000000 --- a/Reference/applemusic-like-lyrics +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 48fb050d2fac2bf4c8b67c973c5ee3f856c6a691 diff --git a/Reference/luna-plugins b/Reference/luna-plugins deleted file mode 160000 index 29204be..0000000 --- a/Reference/luna-plugins +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 29204beb9362803ee82fe5d4fcc9d80c4fa1fb4a diff --git a/plugins/radiant-lyrics-luna/src/Settings.tsx b/plugins/radiant-lyrics-luna/src/Settings.tsx index 6d46947..736f508 100644 --- a/plugins/radiant-lyrics-luna/src/Settings.tsx +++ b/plugins/radiant-lyrics-luna/src/Settings.tsx @@ -112,7 +112,8 @@ export const Settings = () => { desc="Enable glowing effect for lyrics & Font Styling Changes" checked={lyricsGlowEnabled} onChange={(_: unknown, checked: boolean) => { - setLyricsGlowEnabled((settings.lyricsGlowEnabled = checked)); + settings.lyricsGlowEnabled = checked; + setLyricsGlowEnabled(checked); // Update styles immediately when setting changes if ((window as any).updateRadiantLyricsStyles) { (window as any).updateRadiantLyricsStyles(); @@ -124,7 +125,8 @@ export const Settings = () => { desc="Apply glow to the track title" checked={trackTitleGlow} onChange={(_: unknown, checked: boolean) => { - setTrackTitleGlow((settings.trackTitleGlow = checked)); + settings.trackTitleGlow = checked; + setTrackTitleGlow(checked); if ((window as any).updateRadiantLyricsStyles) { (window as any).updateRadiantLyricsStyles(); } @@ -139,7 +141,8 @@ export const Settings = () => { step={1} value={textGlow} onNumber={(value: number) => { - setTextGlow((settings.textGlow = value)); + settings.textGlow = value; + setTextGlow(value); // Update variables immediately when setting changes if ((window as any).updateRadiantLyricsTextGlow) { (window as any).updateRadiantLyricsTextGlow(); @@ -152,7 +155,8 @@ export const Settings = () => { desc="Adds a dropdown to the Lyrics tab that auto-switches to Play Queue when lyrics aren't available" checked={stickyLyricsFeature} onChange={(_: unknown, checked: boolean) => { - setStickyLyricsFeature((settings.stickyLyricsFeature = checked)); + settings.stickyLyricsFeature = checked; + setStickyLyricsFeature(checked); if ((window as any).updateStickyLyricsFeature) { (window as any).updateStickyLyricsFeature(); } @@ -163,7 +167,8 @@ export const Settings = () => { desc="Enable hide/unhide UI functionality with toggle buttons" checked={hideUIEnabled} onChange={(_: unknown, checked: boolean) => { - setHideUIEnabled((settings.hideUIEnabled = checked)); + settings.hideUIEnabled = checked; + setHideUIEnabled(checked); }} /> {hideUIEnabled && ( @@ -173,7 +178,8 @@ export const Settings = () => { checked={playerBarVisible} onChange={(_: unknown, checked: boolean) => { console.log("Player Bar Visibility:", checked ? "visible" : "hidden"); - setPlayerBarVisible((settings.playerBarVisible = checked)); + settings.playerBarVisible = checked; + setPlayerBarVisible(checked); // Update styles immediately when setting changes if ((window as any).updateRadiantLyricsStyles) { (window as any).updateRadiantLyricsStyles(); @@ -186,7 +192,8 @@ export const Settings = () => { desc="Floating rounded player bar with backdrop blur" checked={floatingPlayerBar} onChange={(_: unknown, checked: boolean) => { - setFloatingPlayerBar((settings.floatingPlayerBar = checked)); + settings.floatingPlayerBar = checked; + setFloatingPlayerBar(checked); if ((window as any).updateRadiantLyricsStyles) { (window as any).updateRadiantLyricsStyles(); } @@ -202,7 +209,8 @@ export const Settings = () => { step={1} value={playerBarRadius} onNumber={(value: number) => { - setPlayerBarRadius((settings.playerBarRadius = value)); + settings.playerBarRadius = value; + setPlayerBarRadius(value); (window as any).updateRadiantLyricsPlayerBarTint?.(); }} /> @@ -214,7 +222,8 @@ export const Settings = () => { step={1} value={playerBarSpacing} onNumber={(value: number) => { - setPlayerBarSpacing((settings.playerBarSpacing = value)); + settings.playerBarSpacing = value; + setPlayerBarSpacing(value); (window as any).updateRadiantLyricsPlayerBarTint?.(); }} /> @@ -288,16 +297,18 @@ export const Settings = () => { step={1} value={playerBarTint} onNumber={(value: number) => { - setPlayerBarTint((settings.playerBarTint = value)); + settings.playerBarTint = value; + setPlayerBarTint(value); (window as any).updateRadiantLyricsPlayerBarTint?.(); }} /> {/* Color swatch — positioned just left of the value box */} -