From 06c4adf54be1b89a77e6f1debd9ea01ae45ac670 Mon Sep 17 00:00:00 2001 From: meowarex Date: Sun, 17 May 2026 13:29:38 +0000 Subject: [PATCH] fix(ci): use pnpm 11 `allowBuilds` syntax and pin pnpm version The previous fix (#119) used `onlyBuiltDependencies` in pnpm-workspace.yaml, but the CI runner resolved `version: latest` to pnpm 11.1.2, where that key was removed and replaced by `allowBuilds` (a map of name -> bool). The `pnpm.onlyBuiltDependencies` block in package.json doesn't apply at the workspace level either, so esbuild was still being ignored. Changes: - pnpm-workspace.yaml: replace `onlyBuiltDependencies: [esbuild]` with `allowBuilds: { esbuild: true }` (pnpm 11 syntax). - package.json: add `packageManager: pnpm@11.1.2` so the version is reproducible across CI and local; drop the now-dead `pnpm` block. - .github/workflows/build.yml: drop `version: latest` from pnpm/action-setup; the action reads the version from `packageManager`. --- .github/workflows/build.yml | 3 +-- package.json | 6 +----- pnpm-workspace.yaml | 6 ++++-- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 722a0f6..abbe1b2 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -13,8 +13,7 @@ jobs: - name: Install pnpm 📥 uses: pnpm/action-setup@v4 - with: - version: latest + # Version is read from `packageManager` in package.json for reproducible builds. - name: Install Node.js 📥 uses: actions/setup-node@v4 diff --git a/package.json b/package.json index 2b1e692..b164743 100644 --- a/package.json +++ b/package.json @@ -2,6 +2,7 @@ "name": "@meowarex/TidalLuna-Plugins", "description": "A Collection of Plugins for TidalLuna", "type": "module", + "packageManager": "pnpm@11.1.2", "scripts": { "watch": "concurrently \"pnpm:build --watch\" pnpm:serve", "build": "rimraf ./dist && tsx esbuild.config.ts", @@ -18,10 +19,5 @@ "rimraf": "^6.0.1", "tsx": "^4.19.4", "typescript": "^5.8.3" - }, - "pnpm": { - "onlyBuiltDependencies": [ - "esbuild" - ] } } diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml index 863f105..ea060f4 100644 --- a/pnpm-workspace.yaml +++ b/pnpm-workspace.yaml @@ -1,5 +1,7 @@ packages: - "plugins/*" -onlyBuiltDependencies: - - esbuild +# pnpm 11 renamed `onlyBuiltDependencies` (list) to `allowBuilds` (map of name -> bool). +# This whitelists postinstall/build scripts non-interactively in CI. +allowBuilds: + esbuild: true